Contributing to PureScript Readme

#1

Really minor thing, but the logo in the README is not very legible in GitHub’s “dark mode”:

image
image2018×600 43.8 KB

The contribution guidelines suggest opening an issue before opening a PR, and the New Issue page recommends discussing any non-compiler issues here, so here I am :slight_smile:. Would a change that converts the logo to SVG, and responds to changes in the prefers-color-scheme media query be a welcome contribution?

2021-01-28 19.22.36
2021-01-28 19.22.361613×828 588 KB

4 Likes
#2

I don’t expect anyone to object to the darkmode fix.

Wondering if those contribution guidelines should be modified to allow direct PRs for stuff like this.

1 Like
#3

When it says “work on the compiler”, it really just means “work that would result in a PR to the purescript/purescript repo”, so please feel free to move this discussion to an issue/PR there :slight_smile:

2 Likes